-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
denial of service #30
Comments
That's a good point. The X-Real-IP header is set by my nginx reverse proxy. So it's not a problem for textbelt.com. However, if you are running this on your own, you will need to set that header correctly. I should update the documentation to reflect this. 41abd43 adds an example nginx configuration. |
Hm. Can't you get the ipaddress in a proper way? Without setting this header... Also, you are not handling proxys, x-forwarded-for is the "standard" header for those. Meaning I could get a list of proxys and send more then allowed quota. |
Without setting the header, all forwarded nginx traffic will appear to originate from 127.0.0.1. Unfortunately, people can always abuse IP-based limits with proxies. Using X-Forwarded-For instead of X-Real-IP won't prevent this. The intent of the header check is just to allow the server to run behind a load balancer. If the server isn't behind a load balancer, the current check would let an attacker spoof their rate limited IP by setting the header. |
IP rate limiting has been removed. |
You clame a limit based on ipaddress, however you read that "address" from httpheaders, X-real-ip, which I assume can be anything I as sender can set.
So, the limit will not work.
The text was updated successfully, but these errors were encountered: