Fix proxying non-ASCII (coder#6154)

This only affects the path proxy since `req.originalUrl` is in escaped format.
typoniels · Apr 25, 2023 · 951d8ac · 951d8ac
1 parent 2e17735
commit 951d8ac
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/node/routes/pathProxy.ts b/src/node/routes/pathProxy.ts
@@ -11,7 +11,7 @@ const getProxyTarget = (req: Request, passthroughPath?: boolean): string => {
     return `http://0.0.0.0:${req.params.port}/${req.originalUrl}`
   }
   const query = qs.stringify(req.query)
-  return `http://0.0.0.0:${req.params.port}/${req.params[0] || ""}${query ? `?${query}` : ""}`
+  return encodeURI(`http://0.0.0.0:${req.params.port}${req.params[0] || ""}${query ? `?${query}` : ""}`)
 }
 
 export async function proxy(

diff --git a/test/unit/node/proxy.test.ts b/test/unit/node/proxy.test.ts
@@ -187,6 +187,17 @@ describe("proxy", () => {
       })
     }).rejects.toThrow()
   })
+
+  it("should proxy non-ASCII", async () => {
+    e.get("*", (req, res) => {
+      res.json("ほげ")
+    })
+    codeServer = await integration.setup(["--auth=none"], "")
+    const resp = await codeServer.fetch(proxyPath.replace("wsup", "ほげ"))
+    expect(resp.status).toBe(200)
+    const json = await resp.json()
+    expect(json).toBe("ほげ")
+  })
 })
 
 // NOTE@jsjoeio