-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: blog post for v7 #8400
docs: blog post for v7 #8400
Conversation
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8400 +/- ##
==========================================
- Coverage 87.78% 86.94% -0.84%
==========================================
Files 397 252 -145
Lines 13821 12251 -1570
Branches 4067 3861 -206
==========================================
- Hits 12133 10652 -1481
+ Misses 1391 1332 -59
+ Partials 297 267 -30
Flags with carried forward coverage won't be shown. Click here to find out more. |
packages/website/blog/2024-02-12-announcing-typescript-eslint-v7.md
Outdated
Show resolved
Hide resolved
## Installation | ||
|
||
```bash npm2yarn | ||
npm i typescript-eslint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TS eslint is usually used as a dev tool. So would it make sense to instruct to install it with -D?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good as a start! 🚀
Requesting changes on a bit more info.
packages/website/blog/2024-02-12-announcing-typescript-eslint-v7.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-02-12-announcing-typescript-eslint-v7.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-02-12-announcing-typescript-eslint-v7.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-02-12-announcing-typescript-eslint-v7.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Whoohoo!
This looks great, thanks for all the writing-up. I just left some small things inline - nothing blocking IMO.
packages/website/blog/2024-02-12-announcing-typescript-eslint-v7.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-02-12-announcing-typescript-eslint-v7.md
Outdated
Show resolved
Hide resolved
packages/website/blog/2024-02-12-announcing-typescript-eslint-v7.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Goldberg ✨ <[email protected]>
Regarding the Node.js engine requirements:
typescript-eslint/package.json Lines 52 to 54 in b27de99
the ESLint team decided to use
This is because v20 LTS started from https://nodejs.org/en/blog/release/v20.9.0 Either the blog post or the |
Oh looks like I didn't copy past correctly. With our next major well bump it properly. |
Thanks for the confirmation. I understand that it is a breaking change, but enforcing v20 LTS in a minor release seems viable. |
PR Checklist
Overview
Adds a blog post for the v7 release to summarise the changes and announce our new package.