Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: blog post for v7 #8400

Merged
merged 3 commits into from
Feb 9, 2024
Merged

docs: blog post for v7 #8400

merged 3 commits into from
Feb 9, 2024

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

Adds a blog post for the v7 release to summarise the changes and announce our new package.

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Feb 7, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Feb 7, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 064a142
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65c694f98214470008621253
😎 Deploy Preview https://deploy-preview-8400--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Feb 7, 2024

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ef5f4b) 87.78% compared to head (064a142) 86.94%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8400      +/-   ##
==========================================
- Coverage   87.78%   86.94%   -0.84%     
==========================================
  Files         397      252     -145     
  Lines       13821    12251    -1570     
  Branches     4067     3861     -206     
==========================================
- Hits        12133    10652    -1481     
+ Misses       1391     1332      -59     
+ Partials      297      267      -30     
Flag Coverage Δ
unittest 86.94% <ø> (-0.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 147 files with indirect coverage changes

## Installation

```bash npm2yarn
npm i typescript-eslint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS eslint is usually used as a dev tool. So would it make sense to instruct to install it with -D?

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as a start! 🚀

Requesting changes on a bit more info.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Feb 7, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Feb 9, 2024
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Feb 9, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Whoohoo!

This looks great, thanks for all the writing-up. I just left some small things inline - nothing blocking IMO.

Co-authored-by: Josh Goldberg ✨ <[email protected]>
@bradzacher bradzacher merged commit f569553 into main Feb 9, 2024
63 checks passed
@bradzacher bradzacher deleted the v7-blog-post branch February 9, 2024 21:25
@hyunbinseo
Copy link

Regarding the Node.js engine requirements:

Update Node.js engine requirement to ^18.18.0 || >=20.0.0.

Note that this is the same requirement that ESLint v9 will impose.

"engines": {
"node": "^18.18.0 || >=20.0.0"
},

the ESLint team decided to use ^18.18.0 || ^20.9.0.

This is because v20 LTS started from v20.9.0.

https://nodejs.org/en/blog/release/v20.9.0

Either the blog post or the package.json should be updated?

@bradzacher
Copy link
Member Author

Oh looks like I didn't copy past correctly.
Oh well - it's close enough really. If someone's on v20 it should be close to a no-op for them to upgrade to v20.9

With our next major well bump it properly.

@hyunbinseo
Copy link

Thanks for the confirmation.

I understand that it is a breaking change, but enforcing v20 LTS in a minor release seems viable.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📣 Upcoming v7 Major Release
5 participants