Fix active callback multi load #408
Open
+156
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR tries to accomplish
active
event, even ifWebFont.load
is called multiple times in successionHow it accomplishes them
FontModulesLoadCounter
to keep track of the modules being loaded and which is the last one being processed as part of aWebFont.load
requestFontWatchRunner
andNativeFontWatchRunner
so that they are easier to test usingjasmine
webfont.spec
to test that the active event triggers twice for twoWebFont.load
calls