Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active callback multi load #408

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dengjeffrey
Copy link

What this PR tries to accomplish

How it accomplishes them

Fixes #309

  • Adds an object FontModulesLoadCounter to keep track of the modules being loaded and which is the last one being processed as part of a WebFont.load request
  • Breaks down the methods in FontWatchRunner and NativeFontWatchRunner so that they are easier to test using jasmine
  • Adds an additional test to the webfont.spec to test that the active event triggers twice for two WebFont.load calls

@nuthinking
Copy link

Interesting improvement. Shame the repo is abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

active-event not being triggered when two calls made back to back
2 participants