Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let ddev manage config by default #5

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

jkaeser
Copy link
Contributor

@jkaeser jkaeser commented Jul 8, 2024

Adding this flag indicates the file is managed by ddev, which I think is a good default behavior. Some benefits:

  • indicates to users this is something created by a third-party (especially helpful when working on a team)
  • ddev can auto-update the config when users update to newer versions
  • ddev can clean up the config if users remove the add-on

Thanks for putting this add-on together!

@tyler36 tyler36 merged commit 4417773 into tyler36:main Jul 8, 2024
2 checks passed
@tyler36
Copy link
Owner

tyler36 commented Jul 8, 2024

Oops. Good catch!

Thank you for the PR. Once the tests pass, I'll merge and make a new release.

@tyler36
Copy link
Owner

tyler36 commented Jul 8, 2024

Available in 0.2. You need to manually delete the file (or add #ddev-generated) to any current projects so that DDEV will start tracking it again.

Thanks again for submitting the PR.

@jkaeser jkaeser deleted the mark-config-generated branch July 10, 2024 15:52
@tyler36 tyler36 mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants