simplify launch command (#6)

* Improve instructions * Mark config as generated by ddev * simplify launch command --------- Co-authored-by: Christian López Espínola <[email protected]> Co-authored-by: John Kaeser <[email protected]> Co-authored-by: tyler36 <[email protected]>
tyler36 · Oct 8, 2024 · d9f6a53 · d9f6a53
1 parent f591ebc
commit d9f6a53
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -34,6 +34,10 @@ The addon assumes the developer is correctly installed and configured Storybook
 ddev get tyler36/ddev-storybook
 ddev restart
 ```
+2. Install storybook if you haven't already. See the [Storybook get started page](https://storybook.js.org/docs/get-started/install) for instructions. E.g.
+```shell
+ddev exec npx storybook@latest init
+```
 
 ## Usage
 

diff --git a/commands/host/storybook b/commands/host/storybook
@@ -21,22 +21,7 @@ startStorybookServer () {
 
 # Open storybook in prefered browser. This assumes the server is running
 launch () {
-  FULLURL="${DDEV_PRIMARY_URL}:6006"
-  case $OSTYPE in
-    linux-gnu)
-      if [[ ! -z "${GITPOD_INSTANCE_ID}" ]]; then
-        gp preview ${FULLURL}
-      else
-        xdg-open ${FULLURL}
-      fi
-      ;;
-    "darwin"*)
-      open ${FULLURL}
-      ;;
-    "win*"* | "msys"*)
-      start ${FULLURL}
-      ;;
-    esac
+  ddev launch :6006
 }
 
 

diff --git a/config.storybook.yaml b/config.storybook.yaml
@@ -1,3 +1,4 @@
+#ddev-generated
 web_extra_exposed_ports:
   - name: storybook
     container_port: 6006