Added support for creates views and creates jobs into view #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey sorry I've been neglecting this project for a while. Thanks for this submission. |
| @@ -351,3 +352,36 @@ def wait_for_build(self, jobname, poll_interval=3): | |||
| sys.stdout.write('.') | |||
| sys.stdout.flush() | |||
| print('') | |||
|
|
|||
| def createJobIntoView(self, jobname, viewname, config_file, **context): | |||
There was a problem hiding this comment.
I'd rather have the view name as an optional argument in the existing create method (viewname=None as default).
It makes the API simpler IMO. It also means less duplication of code.
What do you think?
|
Nice. Do you think you could add a test as well? Let me know if you need assistance with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the create_view method to create a jenkins view and the createJobIntoView method to creates job inside a specific view.