Added indicators from tushare #661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bull Bear Index BBI
Changed input arguments
Tested on some data to see if it returns the same as the tushare function it is based on
|
Hello @andymc31, Cool! However, could you check out the development branch and see if that needs to be fixed. Fixes and all flow through it. Also individual indicator PRs are much easier to merge than a whole group of them. Thanks |
|
It looks like one of the indicators is similar to one in the development branch but the formula looks different. Is there a way to split this existing pull request? |
No idea. 🤷🏼♂️ Sorry, I have basic git skills. 😑 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first time contributing to github so sorry if there are any noob errors.
Files tested individually and seem to work. Will try downloading and seeing if strategies runs with these new indicators.
Do I update the readme now, or when/if you feel my changes are okay to add?