Revert "HTTP Digest Authentication support" (#267) #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 22a776d, reversing changes made to c9f0bae. Per 2024-06-28 discussion in #twisted on libera.chat and post-merge review comments on GitHub [1], this implementation doesn't look spec compliant. [1]: 22a776d#diff-14b7fa3002098fc55f2cdf2bf01a0039eb02598ae1e852170183d5935f4ef4d0R369
|
Yep, my approval was a bit overzealous. While I appreciate @jameshilliard's work and didn't want to delay further, there were gaps in the previous reviews that we should address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 22a776d, reversing
changes made to c9f0bae.
Per 2024-06-28 discussion in #twisted on libera.chat and post-merge
review comments on GitHub, this implementation doesn't look spec
compliant.
I have filed #389 to track adding this feature.