Resolve the deferred returned by send_multiResponse and send_multiRes… #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the deferred returned by
send_multiResponse
andsend_multiResponse_ex
when a handler is provided and the final response has been handled.This makes using
send_multiResponse
andsend_multiResponse_ex
easier if the caller wants toyield
until all responses have been handled. With existing behavior where the returned deferred is never fired and you want toyield
, you're forced to create and track a separateDeferred
, provide it to thehandler
passed to the calledsend..
method, and both fire that deferred and returnTrue
after the last response is handled.This change will not affect any existing callers of the methods prior behavior was that the returned deferred did nothing
Contributor Checklist:
docs/source/NEWS.rst
CONTRIBUTING.rst
.