Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if key in self._object_class_keys #220

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

check if key in self._object_class_keys #220

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f886767
check if key in self._object_class_keys
Dec 1, 2020
b9cdd0a
Merge branch 'master' into master
graingert Mar 1, 2021
8e5a9e8
Merge branch 'master' into master
glyph Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ldaptor/protocols/ldap/ldapsyntax.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ def toWire(self):
lst = list(self.items())
lst.sort()
for key, values in lst:
if key != "objectClass":
if key not in self._object_class_keys:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just above "objectClass" is handled explicitly too, does that need to use _object_class_keys ?

        objectClasses = list(self.get("objectClass", []))
        objectClasses.sort()
        a.append(("objectClass", objectClasses))

a.append((key, values))
return ldif.asLDIF(self.dn.getText(), a)

Expand Down