Remove Deferred cancellation on client reset #562
Conversation
See twisted#546. We have been running a similar patch on our enterprise production systems for about 6 months with no issues, and critically we have stopped getting issues on client resets.
|
without automated tests is hard to know if this works or not. I am not using klein, so I don't know. It was just a general comment Also, I am not sure why the CI was not triggered for this PR. |
There was a problem hiding this comment.
This needs automated tests, as @adiroiban said. But also, this functionality exists for a reason, and I explained some of the design constraints on #562. (Thanks for writing up the issue separately from the PR so we can discuss the design & implementation separately :))
|
I'm also not sure what's going on with CI; sorry that it's broken. Can you reword / force-push or push another commit to see if it's just a flake on github's side? |
|
I'm going to close until discussion at #546 is resolved. |
See #546.
We have been running a similar patch on our enterprise production systems for about 6 months with no issues, and critically we have stopped getting issues on client resets.