Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 20.6 (old branch) #329

Closed
wants to merge 33 commits into from
Closed

Release 20.6 (old branch) #329

wants to merge 33 commits into from

Conversation

wsanchez
Copy link
Member

@wsanchez wsanchez commented Apr 2, 2020

This PR is a Klein 20.6 release.

The primary goal for this release is to ship all work that's currently been done with support for Python 2.7 before we drop support for Python 2.7, so that we leave the 2.7 users with the latest available progress.

In addition to incrementing the version, this PR adds a script for automating the release process.

@wsanchez wsanchez requested a review from a team as a code owner April 2, 2020 17:46
@wsanchez wsanchez self-assigned this Apr 2, 2020
@wsanchez
Copy link
Member Author

wsanchez commented Apr 2, 2020

@glyph What is the state of #283, and do you want to land that for Python 2? My inclination would be not to, because it's a big feature branch, and Python 2 users won't benefit from any bug fixes to it.

@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #329 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files          48       48           
  Lines        3928     3928           
  Branches      262      262           
=======================================
  Hits         3856     3856           
  Misses         55       55           
  Partials       17       17           
Impacted Files Coverage Δ
src/klein/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80fb394...6a04b24. Read the comment docs.

@glyph
Copy link
Member

glyph commented Apr 2, 2020

@glyph What is the state of #283, and do you want to land that for Python 2? My inclination would be not to, because it's a big feature branch, and Python 2 users won't benefit from any bug fixes to it.

It pretty much works, but it has basically zero test coverage, and I don't have a ton of time to work on it right now. I would not want to hold up any releases because of it.

If someone were to really need such a thing on python 2 after the fact, they can grab the version from that branch. But I think the main point with py2 at this point is compatibility, so I doubt anyone interested in building a major new database-backed system with Klein would want to start there.

@glyph

This comment has been minimized.

@wsanchez

This comment has been minimized.

@wsanchez wsanchez changed the title Release 20.4 [WIP] Release 20.4 Apr 2, 2020
@wsanchez wsanchez marked this pull request as draft April 10, 2020 16:31
@wsanchez wsanchez changed the title [WIP] Release 20.4 Release 20.4 Apr 10, 2020
@wsanchez
Copy link
Member Author

I'm going to drop the idea of getting type hints into this release for Python 2.4 users.

@wsanchez wsanchez changed the title Release 20.4 Release 20.6 May 26, 2020
@wsanchez wsanchez marked this pull request as ready for review May 26, 2020 18:18
@wsanchez
Copy link
Member Author

@hawkowl @glyph @moshez perhaps you want to look over the new release script.

NEWS.rst Show resolved Hide resolved
@@ -1,6 +1,36 @@
NEWS
====

20.6.0 - 2020-06-??
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set the date before releasing.

NEWS.rst Show resolved Hide resolved
Copy link
Contributor

@twm twm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I only had minor notes.

I will probably cargo-cult release.py into Treq since it's a better version of the script I was going to write. Would you mind slapping a copyright/license header on it?

I'm looking forward to the release!

release.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
NEWS.rst Show resolved Hide resolved
* master:
  Remove a bunch of "type: ignore[misc]" comments for Zope interface uses that are no longer triggering mypy, and change calls to interface types to ""type: ignore[operator]".
  Add updates missed by requires.io
  Ignore /docs/
  [requires.io] dependency update
  [requires.io] dependency update
@wsanchez
Copy link
Member Author

wsanchez commented Jun 7, 2020

@twm I was thinking about factoring out release.py into it's own repo for reuse, FYI.

@glyph
Copy link
Member

glyph commented Jun 8, 2020

@twm I was thinking about factoring out release.py into it's own repo for reuse, FYI.

yessssssssssss

@wsanchez wsanchez changed the title Release 20.6 Release 20.6 (old branch) Jun 8, 2020
@wsanchez wsanchez mentioned this pull request Jun 8, 2020
@wsanchez
Copy link
Member Author

wsanchez commented Jun 8, 2020

Renamed the branch, which is now PR #353

@wsanchez wsanchez closed this Jun 8, 2020
@wsanchez wsanchez deleted the release-20.4 branch June 8, 2020 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants