Cleaned up variable name and comments #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private(set) var observervableTypingMemeberList: ObservableFetchRequestResult<PersistentParticipantDataItem>? | ||
| private(set) var observervableTypingMemberList: ObservableFetchRequestResult<PersistentParticipantDataItem>? |
There was a problem hiding this comment.
observableTypingParticipantList sounds more clear
berkus
reviewed
Sep 1, 2022
| @@ -40,7 +40,7 @@ class ConversationViewModel: NSObject { | |||
|
|
|||
| weak var delegate: ConversationViewModelDelegate? | |||
|
|
|||
| // MARK: Init | |||
| // Initialize the Conversation | |||
There was a problem hiding this comment.
Keep the "MARK:" prefix - it shows up in Xcode code minimap.
berkus
reviewed
Sep 1, 2022
| @@ -68,17 +68,17 @@ class ConversationViewModel: NSObject { | |||
| messagesManager.reactToMessage(withSid: sid, withReaction: reaction) | |||
| } | |||
|
|
|||
| // MARK: Deintialization | |||
|
@segheysens hi, could you please address the review comments? |
|
@berkus made these updates! |
Gray-Wind
suggested changes
Oct 6, 2022
| @@ -68,17 +68,17 @@ class ConversationViewModel: NSObject { | |||
| messagesManager.reactToMessage(withSid: sid, withReaction: reaction) | |||
| } | |||
|
|
|||
| // MARK: Deintialization | |||
| // Deinitialization | |||
| deinit { | ||
| // During transition, remove observers | ||
| unsubscribeFromConversationChanges() | ||
| } | ||
|
|
||
| // MARK: Methods | ||
| // Methods |
Gray-Wind
reviewed
Oct 6, 2022
| private func unsubscribeFromConversationChanges() { | ||
| observableConversation?.removeObserver(self) | ||
| observableMessageList.removeObserver(self) | ||
| observervableTypingMemeberList?.removeObserver(self) | ||
| observervableTypingMemberList?.removeObserver(self) |
There was a problem hiding this comment.
Shouldn't it be observableTypingParticipantList?
|
@segheysens hi! Please address the remaining notes and I believe the |
|
@segheysens hi, do you plan to finish up this PR? |
|
@segheysens gentle poke! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio