8495 workflow display relevant columns in workflow related tables #8502
+104
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the display of workflow-related tables by improving column organization and management. Here are the key changes:
- Removed explicit width management from table cells by deleting
tableCellWidthsComponentState.tsand related props, simplifying the table structure - Added new
createdByfield to track workflow creators inworkflow.workspace-entity.tswith corresponding UI updates - Modified workflow table views to show more relevant columns (status, updatedAt, versions, runs) with consistent 150px column widths
- Updated workflow runs and versions views to display better organized information like workflow status, creator, and version details
- Fixed React key prop warnings in workflow drawer components for better rendering performance
The changes improve the display of workflow information while maintaining a clean and consistent table structure.
13 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
.../twenty-front/src/modules/object-record/record-table/states/tableCellWidthsComponentState.ts
Outdated
Show resolved
Hide resolved
...ages/twenty-front/src/modules/workflow/components/RightDrawerWorkflowSelectActionContent.tsx
Outdated
Show resolved
Hide resolved
...twenty-front/src/modules/workflow/components/RightDrawerWorkflowSelectTriggerTypeContent.tsx
Outdated
Show resolved
Hide resolved
...ages/twenty-server/src/modules/workflow/common/standard-objects/workflow.workspace-entity.ts
Show resolved
Hide resolved
martmull
force-pushed
the
8495-workflow-display-relevant-columns-in-workflow-related-tables
branch
from
bc71382
to
da78353
Compare
This reverts commit b034834.
…rkflow-related-tables
thomtrp
approved these changes
Nov 15, 2024
| @@ -129,9 +129,9 @@ export class WorkflowRunWorkspaceEntity extends BaseWorkspaceEntity { | |||
| @WorkspaceField({ | |||
| standardId: WORKFLOW_RUN_STANDARD_FIELD_IDS.createdBy, | |||
| type: FieldMetadataType.ACTOR, | |||
| label: 'Created by', | |||
| label: 'Executed by', | |||
martmull
force-pushed
the
8495-workflow-display-relevant-columns-in-workflow-related-tables
branch
from
2d87ac2
to
b11b100
Compare
martmull
deleted the
8495-workflow-display-relevant-columns-in-workflow-related-tables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
Workflows
WorkflowRuns
WorkflowVersions
Change Created By into Executed By in workflowRuns