Settings Option Card component #8456
Open
+931
−920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOs/FIXMEs:
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR standardizes settings options UI across the application by introducing a new SettingsOptionCardContent component with consistent design patterns.
- Added new
SettingsOptionCardContentcomponent in/settings/components/SettingsOptionCardContent.tsxsupporting toggle, counter, and select variants with standardized styling - Added
AdvancedSettingsWrappercomponent in/settings/components/AdvancedSettingsWrapper.tsxfor consistent advanced mode animations - Replaced custom toggle/input components with standardized
SettingsOptionCardContentin calendar, message, and data model settings - Added new
useExpandedAnimationhook in/settings/hooks/useExpandedAnimation.tsto handle both width/height animations, replacing the previous height-only hook - Added
IconDecimalandIconSlashto TablerIcons for consistent iconography across settings
21 file(s) reviewed, 21 comment(s)
Edit PR Review Bot Settings | Greptile
...ty-front/src/modules/settings/accounts/components/SettingsAccountsCalendarChannelDetails.tsx
Show resolved
Hide resolved
...nty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelDetails.tsx
Show resolved
Hide resolved
...nty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelDetails.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/components/AdvancedSettingsWrapper.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/components/AdvancedSettingsWrapper.tsx
Show resolved
Hide resolved
...ules/settings/data-model/fields/forms/number/components/SettingsDataModelFieldNumberForm.tsx
Show resolved
Hide resolved
...rc/modules/settings/data-model/objects/forms/components/SettingsDataModelObjectAboutForm.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/hooks/useExpandedAnimation.ts
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/hooks/useExpandedAnimation.ts
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/security/SettingsSecurity.tsx
Outdated
Show resolved
Hide resolved
...nty-front/src/modules/settings/accounts/components/SettingsAccountsMessageChannelDetails.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/components/SettingsOptionCardContent.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/components/SettingsOptionCardContent.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/components/SettingsOptionCardContent.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/components/SettingsOptionCardContent.tsx
Outdated
Show resolved
Hide resolved
| variant="counter" | ||
| Icon={IllustrationIconDecimal} | ||
| title="Number of decimals" | ||
| description="Set the number of decimal places" |
There was a problem hiding this comment.
max should not be 100 here!
packages/twenty-front/src/modules/ui/input/components/Select.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-ui/src/display/icon/assets/illustration-briefcase.svg
Outdated
Show resolved
Hide resolved
packages/twenty-ui/src/display/icon/components/IllustrationIconBriefcase.tsx
Outdated
Show resolved
Hide resolved
charlesBochet
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes - #8195