Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add transparency option #40779

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Sep 2, 2024

Description

Adding an option in the navbar to toggle a specific background (disabled by default) to help people see the transparency or not of a component.

Motivation & Context

We were ready to add it to our documentation (which is based on the Bootstrap one) so I try it upstream before all to see if this kind of feature would be needed. Feel free to close the PR if not needed in here.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@coliff
Copy link
Contributor

coliff commented Sep 3, 2024

This is a useful enhancement and implemented really well. On the current docs it's not always clear at a glance if an elements color is the default color or if it has partially transparency - with this change it's much clearer. 👍

Update: Agree that on some pages it has no effect and there's no feedback that anything has changed.. perhaps the button could be moved to the example block next to the Stackblitz button?
image

@XhmikosR
Copy link
Member

XhmikosR commented Sep 3, 2024

I'm not sure we need a new button, I'm not in favor of this, because in most pages it's useless, it doesn't change anything and the button doesn't show any feedback that something has changed.

What we could probably have, though, is this effect more subtle and enabled by default.

But I'd like to hear @mdo's opinion before landing such a change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

3 participants