Dev infra #8241
Draft
Dev infra #8241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuta-sudipg
force-pushed
the
dev-infra
branch
3 times, most recently
from
ef41bb6 to
d0edb8b
Compare
ganthern
force-pushed
the
dev-infra
branch
2 times, most recently
from
a2e991d to
6eb3d92
Compare
we're moving to persisting the import state only on the server, with the files to be imported on disk the only local state that is kept by the importer. Most errors happen during import preparation after we receive the files to import. These can be caught & handled immediately. If no errors happen, the remote state will be set up on the server at this stage and can be subscribed to by the UI by loading it via its ID Some other errors can happen asynchronously while the importer is running in the background. For those, the importer sets a hook to receive and handle them as they happen. any normal state updates are sent to the server in node-mimimi and received in the UI via entity updates. Co-authored-by: nig <[email protected]> Co-authored-by: sug <[email protected]> Co-authored-by: map <[email protected]> Co-authored-by: jhm <[email protected]> Co-authored-by: Kinan <[email protected]> Co-authored-by: abp <[email protected]>
- set status to paused when starting new client. - fix condition in set_progress_action
this will make sure estimation timeout is cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.