Better refreshing state indication for AccountActivity

[Goooler]

Refs #4345 (comment).

[cbeyls]

Note: you can also remove

binding.swipeToRefreshLayout.isRefreshing = true

in AccountActivity (around line 1075). It's better to have the ViewModel as single source of truth for the refreshing state.

[Goooler]

Good catch!

[connyduck]

Now the spinner shows up on the initial load which is very irritating imo.

[cbeyls]

Now the spinner shows up on the initial load which is very irritating imo.

The state could be enriched with some additional information differentiating an initial load from a refresh.

For example, instead of a boolean, use a sealed class:

sealed class LoadingState {
    data object Idle : LoadingState()

    data class Loading(val isRefresh: Boolean) : LoadingState()
}

binding.swipeToRefreshLayout.isRefreshing = it is LoadingState.Loading && it.isRefresh

[connyduck]

Suggested change

	_refreshState.value = RefreshState.REFRESHING
	if (reload) {
	_refreshState.value = RefreshState.REFRESHING
	}

[Goooler]

I didn't notice here is the key point, can we revert 3d283bd and use your logic here, it's a simple state.

  if (reload) {
      _isRefreshing.value = true
  }

[Goooler]

6e48b6a

[cbeyls]

Two loads may still be triggered in parallel during the initial load, because _isRefreshing is not set to true in that case.

Hence I suggest to keep the loading state in a separate field, or merge loading and refreshing states together using a sealed class.

Alternatively, cancel the load in progress before starting a new one.