fixes GEN 2 cloudfunctions function not getting listed

[ashutoshmore658]

This PR fixes following bug issue:
#565

[misraved]

@ashutoshmore658 welcome to Steampipe and thank you so much for raising the PR 👍.

Could you please add the example queries in the PR removing the sensitive data?

[ashutoshmore658]

Sure @misraved , thank you for replying. could you please elaborate ? exactly what are the example queries ?, so that I can get it in to the action.

[misraved]

@ashutoshmore658 please take a look at the following suggestions for the PR:

• Since we are using a new version of the cloud functions, I think it is important to verify if all the Gen 2 cloud functions are getting listed or not. Please add an example query that enlists both the Gen 1 and Gen 2 cloud functions.
• Use the select * from gcp_cloudfunctions_function query on the main and ashutoshmore658:Gcp-CloudFunctions-Gen2-Flooding branch to verify that other columns haven't been affected (difference in the datatype or output structure) by this change.

[ashutoshmore658]

Thank you for the detailed explanation @misraved , I will act accordingly.

[ashutoshmore658]

Hi @misraved ,

with building GCP Steampipe plugin from Gcp-CloudFunctions-Gen2-Flooding branch from this branches code and querying the vpc for cloud function names, in below image you can see all the cloud functions of both GEN 1 origin and GEN 2 origin are also being listed. following images are proofs for the same.

Branch:

Results received:

After removing the branch plugin from the Steampipes plugin directory and switching the branch of the GCP Steampipe back to main branch, rebuilding the plugin from scratch, and reconfiguiring the project, and after that querying the VPC listis only GEN 1 functions .

Results received:

This PR is adding the GEN 2 functions which were missing in previous version of gcp steampipe plugin and it is not breaking anything.

[ashutoshmore658]

@misraved I am adding some more commits in the current PR, but how to show the results, cause security reasons are involved ?

What else is needed to merge this PR ?

[misraved]

@ashutoshmore658 what commits are you trying to add? I feel the results are sufficient for the PR to be merged 👍.

[ashutoshmore658]

@misraved other columns values such as Https Trigress, Ingress Count etc which were missing, or for them should I raise another PR ?
Another confusion is if the results are okay, when we are going to merge this PR

[misraved]

@ashutoshmore658 we can go ahead and raise a new PR for those changes. Meanwhile, let me merge this PR 👍.

Great work 🎉 !!

[ashutoshmore658]

@misraved Thank you, It's been a pleasure collaborating with you.