Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/home #71

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Refactor/home #71

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
29e7c90
initial
Jul 19, 2023
e0f69c9
testing refactor
ramirc5 Jul 20, 2023
0800402
refactored setPullRequest()
ramirc5 Jul 20, 2023
4b8b532
split up some code in home.js to a new file
ramirc5 Jul 21, 2023
e0f232a
got custom hook working
ramirc5 Jul 24, 2023
3ec5cc4
merged refactor/useRepoData
ramirc5 Jul 24, 2023
815469c
removed console.logs
ramirc5 Jul 24, 2023
1003ebb
removed console.logs
ramirc5 Jul 24, 2023
20f9bc7
moved loading to new hook and now using topinfobar where needed to re…
ramirc5 Jul 25, 2023
1941bf8
refactored home view logic
ramirc5 Jul 25, 2023
f4c6092
prettify
ramirc5 Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Components/DOM/VoteStatusButton.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default function VoteStatusButton(props){

const fetchVoteStatus = async () => {
let textMath = voteStatusButton.textMath;
let tsrcPRStatusComponent
let tsrcPRStatusComponent;
try {
tsrcPRStatusComponent = await postGetPullRequest(
user,
Expand Down Expand Up @@ -63,7 +63,6 @@ export default function VoteStatusButton(props){
setVoteNoTotalState(voteNoTotal);
setTsrcPRStatus(tsrcPRStatusComponent);
} catch (error) {
console.log('fetchVoteStatus error:', error)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe VoteStatusButton is outside of the scope of refactoring the extension Home page, also the console log is fine if it is console logging an error in a trycatch

textMath = "";
}
};
Expand Down
Loading