Resolving issue #1 (psql required for Generating tests) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended Documentation
tshprecher
reviewed
Apr 11, 2019
There was a problem hiding this comment.
Thank you for this PR! Had I not overlooked the email I got notifying me of this, I would have done it much sooner. I apologize for that. It wasn't my intention to ignore this. It just happens that someone else put out a PR, so I noticed this one too.
I have just a couple small comments.
| @@ -40,10 +40,18 @@ when this project reaches a stable state. | |||
|
|
|||
| ## Generating test files | |||
|
|
|||
| Setup Environment :- | |||
|
|
|||
| - Install postgres, | |||
There was a problem hiding this comment.
Just a couple small things:
- Up above there's a
Setupsection. I would just add a dependency on Postgres v10.6 (the version I'm coding against). You can add the instructions on how to install that particular version there. - In this section, I would just mention in a sentence or two that the user should make sure he/she has the postgres server running so that
psqlis able to run against each test query. You can keep the instruction on how to start the server if you'd like. Thanks for that.
|
|
There was a problem hiding this comment.
Nit: can you remove this space, and maybe a few more before it? That's mostly my mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending documentation to reflect the steps needed to be performed to setup the environment for generating tests..