Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(API-2025): upgrade legacy branch to Node 16 #49

Merged
merged 3 commits into from
Apr 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 14
registry-url: "https://registry.npmjs.org"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed registry-url - this should not be needed

node-version: 16
- name: Installing dependencies
run: npm i
- name: Build and test
run: npm ci
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm ci instead of npm i

- name: Build
run: npm run build
- name: Release
env:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 16
- name: Installing dependencies
run: npm i
- name: Build and test
run: npm ci
- name: Build
run: npm run build
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
dist
.rpt2_cache/
.rts2_cache_cjs/
.rts2_cache_js/
.rts2_cache_es/
.rts2_cache_umd/
node_modules
.idea
wjohnson-truework marked this conversation as resolved.
Show resolved Hide resolved
node_modules

6 changes: 3 additions & 3 deletions tests/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -362,14 +362,14 @@ test(`create with baseURL`, async t => {

test(`create with baseURL, override per request`, async t => {
const wrappedGretch = create({
baseURL: `http://www.foo.com`
baseURL: `http://www.example.com`
});

const res = await wrappedGretch("/api", {
baseURL: `http://www.bar.com`
baseURL: `http://www.example.net`
}).json();

t.is(res.url, `http://www.bar.com/api`);
t.is(res.url, `http://www.example.net/api`);
});

test(`body not parsed with flush`, async t => {
Expand Down