Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non tc support #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Non tc support #32

wants to merge 2 commits into from

Conversation

sreedeepkesav
Copy link
Contributor

No description provided.

@sreedeepkesav sreedeepkesav requested a review from shubhral March 8, 2022 14:15
@shubhral shubhral added the enhancement New feature or request label Mar 9, 2022
@@ -0,0 +1,29 @@
PODS:
- Flutter (1.0.0)
- truecaller_sdk (0.0.1):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this 0.0.1 stand for? coz our latest version is 0.1.0, so I hope this won't conflict.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was more or less auto downloaded, I'll check again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is like auto generated, let me check, should not cause any problems

switch verificationState {
case .otpInitiated:
map[Constants.String.data] = trueSdk.tokenTtl()
case .otpReceived,
Copy link
Contributor

@shubhral shubhral Mar 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in case of otpReceived, we are not doing anything here. In Android, we pass the OTP to the callback, so shouldn't there be a similar behaviour?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, in case of verifiedBefore, we must pass the profile back as the call back data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of iOS we cannot know if the otp is received or not.
In cas2 of verified before, we will have to tweak the documentation a little bit, so that the app waits for the profile call back, similar to in native sdk @shubhral

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants