Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend/Frontend - apply most of the fixes suggested by SonarCloud from general analysis #536

Merged
merged 58 commits into from
May 17, 2024
Merged

Backend/Frontend - apply most of the fixes suggested by SonarCloud from general analysis #536

merged 58 commits into from
May 17, 2024

Conversation

trolit
Copy link
Owner

@trolit trolit commented May 17, 2024

No description provided.

trolit added 30 commits May 17, 2024 17:51
@trolit
Add missing await keyword to async method execution
e3dc0df
@trolit
Fix if braces typo
271b921
@trolit
Remove unnecessary nested template literals from data source file
2489740
@trolit
Fix one more nested template literal :D
4cac890
@trolit
add initial value to reduce
c6bda6f
@trolit
Use cast instead of as keyword
e057983
@trolit
remove unnecessary assertion
5c8a320
@trolit
Remove redundant return statement from mapper constructor
bd84382
@trolit
Throw object instead of literal
25b0101
@trolit
Use nullish coalescing op instead of condition
e1f7cb7
@trolit
Remove request cast for expanded arg type
c6541da
@trolit
Remove redundant double cast of key
75c1240
@trolit
Simplify tag save or return statement
5fcd549
@trolit
Fix exception not being thrown
13ca693
@trolit
Use type alias for DateService arg
ec7f0e7
@trolit
Remove optional operator doubling
35004d4
@trolit
Use optional chain instead of alternative
5d090c4
@trolit
Use optional chain instead of alternative
2a63108
@trolit
Remove optional operator doubling
d964edb
@trolit
include promised return type for custom integration test
39db0b8
@trolit
Use optional chain
5339b35
@trolit
use nullish coalescing operator
06bb562
@trolit
use nullish coalescing operator
0887e6c
@trolit
use nullish coalescing operator
6a00dfd
@trolit
remove unused import
2160573
@trolit
remove unused import
e925f3b
@trolit
remove unused import
5d88c26
@trolit
remove unnecessary use of conditional expression
c1d26f2
@trolit
remove unused variable
4d677d9
@trolit
throw object error instead of literal
0ca0ce3
trolit added 20 commits May 17, 2024 20:03
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@trolit trolit merged commit 58ad499 into develop May 17, 2024
2 checks passed
@trolit trolit deleted the patch/apply-most-of-the-fixes-suggested-by-sonarcloud branch May 17, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend frontend patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trolit