3.0.2 - consider all step exceptions for scenario overview (#303)

* added makefile * consider all step exceptions
trivago · Dec 22, 2022 · d8126a5 · d8126a5
1 parent 2551676
commit d8126a5
Show file tree

Hide file tree

Showing 9 changed files with 26 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 Back to [Readme](README.md).
 
+## [3.0.2] - 2022-12-22
+
+### Fixed
+* Exception message for non-given step was not shown in overview (#302)
+
 ## [3.0.1] - 2022-12-15
 
 ### Fixed
@@ -692,6 +697,7 @@ steps with status `pending` or `undefined` (default value is `false`) (#74)
 
 Initial project version on GitHub and Maven Central.
 
+[3.0.2]: https://github.com/trivago/cluecumber-report-plugin/tree/3.0.2
 [3.0.1]: https://github.com/trivago/cluecumber-report-plugin/tree/3.0.1
 [3.0.0]: https://github.com/trivago/cluecumber-report-plugin/tree/3.0.0
 [2.9.4]: https://github.com/trivago/cluecumber-report-plugin/tree/2.9.4

diff --git a/core/pom.xml b/core/pom.xml
@@ -6,13 +6,13 @@
     <modelVersion>4.0.0</modelVersion>
 
     <artifactId>cluecumber-core</artifactId>
-    <version>3.0.1</version>
+    <version>3.0.2</version>
     <packaging>jar</packaging>
 
     <parent>
         <artifactId>cluecumber-parent</artifactId>
         <groupId>com.trivago.rta</groupId>
-        <version>3.0.1</version>
+        <version>3.0.2</version>
     </parent>
 
     <name>Cluecumber Core</name>

diff --git a/engine/pom.xml b/engine/pom.xml
@@ -8,11 +8,11 @@
     <parent>
         <artifactId>cluecumber-parent</artifactId>
         <groupId>com.trivago.rta</groupId>
-        <version>3.0.1</version>
+        <version>3.0.2</version>
     </parent>
 
     <artifactId>cluecumber-engine</artifactId>
-    <version>3.0.1</version>
+    <version>3.0.2</version>
     <packaging>jar</packaging>
 
     <name>Cluecumber Engine</name>

diff --git a/engine/src/main/java/com/trivago/cluecumber/engine/json/pojo/Element.java b/engine/src/main/java/com/trivago/cluecumber/engine/json/pojo/Element.java
@@ -288,22 +288,22 @@ public String getFirstExceptionClass() {
 
     public String getFirstException() {
         String exception = getResultListException(before);
-        if (exception != null){
+        if (exception != null && !exception.isEmpty()){
             return exception;
         }
 
         exception = getStepException(backgroundSteps);
-        if (exception != null){
+        if (exception != null && !exception.isEmpty()){
             return exception;
         }
 
         exception = getStepException(steps);
-        if (exception != null){
+        if (exception != null && !exception.isEmpty()){
             return RenderingUtils.escapeHTML(exception);
         }
 
         exception = getResultListException(after);
-        if (exception != null){
+        if (exception != null && !exception.isEmpty()){
             return exception;
         }
         return "";
@@ -312,17 +312,17 @@ public String getFirstException() {
     private String getStepException(final List<Step> steps) {
         for (Step step : steps) {
             String exception = getResultListException(step.getBefore());
-            if (exception != null){
+            if (exception != null && !exception.isEmpty()){
                 return exception;
             }
 
             exception = step.getResult().getErrorMessage();
-            if (exception != null) {
+            if (exception != null && !exception.isEmpty()) {
                 return exception;
             }
 
             exception = getResultListException(step.getAfter());
-            if (exception != null){
+            if (exception != null && !exception.isEmpty()){
                 return exception;
             }
         }

diff --git a/examples/core-example/pom.xml b/examples/core-example/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>blog.softwaretester</groupId>
     <artifactId>core-example</artifactId>
-    <version>3.0.1</version>
+    <version>3.0.2</version>
     <packaging>pom</packaging>
 
     <properties>

diff --git a/examples/maven-example/pom.xml b/examples/maven-example/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>blog.softwaretester</groupId>
     <artifactId>cluecumber-test-project</artifactId>
-    <version>3.0.1</version>
+    <version>3.0.2</version>
     <packaging>pom</packaging>
 
     <properties>

diff --git a/makefile b/makefile
@@ -0,0 +1,4 @@
+build-and-test:
+	mvn clean install
+	mvn verify -f=examples/maven-example
+	open examples/maven-example/target/cluecumber-report/index.html
diff --git a/maven/pom.xml b/maven/pom.xml
@@ -7,12 +7,12 @@
 
     <artifactId>cluecumber-maven</artifactId>
     <packaging>maven-plugin</packaging>
-    <version>3.0.1</version>
+    <version>3.0.2</version>
 
     <parent>
         <artifactId>cluecumber-parent</artifactId>
         <groupId>com.trivago.rta</groupId>
-        <version>3.0.1</version>
+        <version>3.0.2</version>
     </parent>
 
     <name>Cluecumber Maven</name>

diff --git a/pom.xml b/pom.xml
@@ -7,7 +7,7 @@
 
     <groupId>com.trivago.rta</groupId>
     <artifactId>cluecumber-parent</artifactId>
-    <version>3.0.1</version>
+    <version>3.0.2</version>
     <packaging>pom</packaging>
 
     <name>Cluecumber Parent</name>