Keep refresh token if the server does not return a new one on token refresh #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you gotten the chance to take a look at this? Let me know what you guys think |
| /// - parameter accessToken: The new access token. | ||
| /// | ||
| /// - returns: The updated access token. | ||
| private func updateAccessToken(accessToken: OAuthAccessToken) -> OAuthAccessToken { |
There was a problem hiding this comment.
I think I would prefer this being part of the set part of accessToken just so that we always get the expected behaviour when setting a new token directly. What do you think?
|
@poislagarde Thanks for the nice pull request! 🎉 I've added some smaller comments. When those are addressed, I would be happy to merge this 👍 |
|
@bckr sorry about the delay. I'll try to look at this during the weekend! |
|
@poislagarde Awesome 👍 |
ugoArangino
force-pushed
the
master
branch
3 times, most recently
from
4c3875f to
5551b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82