[AMD] Support int DotOp for RDNA3 #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joviliast
commented
May 14, 2024
•
joviliast
commented
- Fixed int8 tests for Navi31
- Generate wmma instructions for int8 or int4 operands
- Convert operands to fp32 if initial type more than int8
- Convert result back to initial type after dot
- Add lit tests
binarman
reviewed
May 15, 2024
third_party/amd/lib/TritonAMDGPUTransforms/AccelerateAMDMatmul.cpp
Outdated
Show resolved
Hide resolved
joviliast
force-pushed
the
inttofp32
branch
2 times, most recently
from
16660b0
to
2452b7d
Compare
joviliast
changed the title
antiagainst
requested changes
May 22, 2024
third_party/amd/lib/TritonAMDGPUTransforms/AccelerateAMDMatmul.cpp
Outdated
Show resolved
Hide resolved
third_party/amd/lib/TritonAMDGPUTransforms/AccelerateAMDMatmul.cpp
Outdated
Show resolved
Hide resolved
third_party/amd/lib/TritonAMDGPUTransforms/AccelerateAMDMatmul.cpp
Outdated
Show resolved
Hide resolved
third_party/amd/lib/TritonAMDGPUTransforms/AccelerateAMDMatmul.cpp
Outdated
Show resolved
Hide resolved
- Fixed int8 tests for Navi31 - Generate wmma instructions for int8 or int4 operands - Convert operands to fp32 if initial type more than int8 - Convert result back to initial type after dot - Add lit tests Signed-off-by: Ilya Veselov <[email protected]>
antiagainst
changed the title
antiagainst
changed the title
antiagainst
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.