[AOT][BACKEND][AMD] Refactor Triton AOT function and add AMD GPU support #3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayfurmanek
commented
Apr 24, 2024
binarman
reviewed
Apr 24, 2024
| #include <stdint.h> | ||
| #include <stdio.h> | ||
|
|
||
| #endif |
There was a problem hiding this comment.
Is this line placed here instead of end of a file intentionally?
There was a problem hiding this comment.
I think so. That is a bit odd but its the same in third_party/nvidia/backend/tools/compile.h which is how it was before. I just made it the same on the hip side.
jayfurmanek
force-pushed
the
refactor_aot
branch
from
e0e1490
to
be82f2a
Compare
jayfurmanek
requested review from
antiagainst,
zhanglx13 and
ptillet
as code owners
|
@jayfurmanek is there any plan to add cross-compiling support? |
to conform to the new backend model. Backend specific files (compiler.c, link.py) have been moved the appropriate places in the third_party directory. AMD GPU support has also been added to the AOT compiler, launcher and unit tests.
jayfurmanek
force-pushed
the
refactor_aot
branch
from
be82f2a
to
63135f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the Triton AOT function to conform to the new backend model. Backend specific files (compiler.c, link.py) have been moved the appropriate places in the third_party directory.
AMD GPU support has also been added to the AOT compiler, launcher and unit tests.