Run Engine 2.0 (alpha) #1575

nicktrn · 2024-12-17T18:23:00Z

Good luck @coderabbitai

…ogs to the runs for debugging

# Conflicts: # packages/core/src/v3/schemas/common.ts

…ring the child

…focused

changeset-bot · 2024-12-17T18:23:04Z

⚠️ No Changeset found

Latest commit: a759bf7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2024-12-17T18:23:12Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

84 files out of 229 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2024-12-18T17:00:30Z

trigger.dev

npm i https://pkg.pr.new/triggerdotdev/trigger.dev@1575

@trigger.dev/core

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/core@1575

@trigger.dev/build

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/build@1575

@trigger.dev/rsc

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/rsc@1575

@trigger.dev/react-hooks

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/react-hooks@1575

@trigger.dev/sdk

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/sdk@1575

@trigger.dev/worker

npm i https://pkg.pr.new/triggerdotdev/trigger.dev/@trigger.dev/worker@1575

commit: a759bf7

matt-aitken · 2024-12-19T16:35:22Z

internal-packages/database/prisma/schema.prisma

@@ -419,6 +421,9 @@ model RuntimeEnvironment {
  currentSession       RuntimeEnvironmentSession?  @relation("currentSession", fields: [currentSessionId], references: [id], onDelete: SetNull, onUpdate: Cascade)
  currentSessionId     String?
  taskRunNumberCounter TaskRunNumberCounter[]
+  taskRunCheckpoints   TaskRunCheckpoint[]
+  waitpoints           Waitpoint[]
+  workerInstance       WorkerInstance[]


Ideally this would be plural

matt-aitken and others added 30 commits October 25, 2024 19:23

Example of using the error execution snapshot

b95404e

Emit an event on executionSnapshotCreated, so we can add admin only l…

431ec06

…ogs to the runs for debugging

Remove the todo from complete attempt

682c808

Merge remote-tracking branch 'origin/main' into run-engine-2

3d95424

Merge remote-tracking branch 'origin/main' into run-engine-2

e5e7425

# Conflicts: # packages/core/src/v3/schemas/common.ts

run engine singleton

90972f5

fix engine shutdown and redis errors in tests

8d22cc7

move shared test setup to internal package

41d79ba

add run engine errors to should retry helper

37e3f12

add missing consts export

a659f9d

Latest lockfile

c255592

Cleaned up getting the latest snapshot. Started on attempt failures

7388b87

Work on reattempting

c83d6bd

Added Waitpoint outputIsError column

e9062be

Work on dealing with attempts that fail

d01b888

runs triggered via run engine should be V2

3194257

current unmanaged deployment label

c66d3fe

schema changes

79d4432

run engine base service extension

8089397

Merge remote-tracking branch 'origin/main' into run-engine-2

d036d7a

Improved the triggerAndWait test to start the parentRun before trigge…

2dab2ea

…ring the child

Simplified the tests so there’s less repeated checks, keep them more …

8c3cabf

…focused

Failed run test passing

cb26957

hidden worker groups

dc4a88c

feature flag helpers

6bb7a4c

add basic worker package

a7ecfc9

add worker group services

41eb240

get master queue from default worker group on trigger

accee54

basic worker api routes

a6a7b40

add worker group tests

a035ab1

nicktrn added 2 commits December 17, 2024 16:11

add basic engine version check via current deploy

d3a3951

new run engine will default to node 22 runtime

476b20f

nicktrn added 15 commits December 18, 2024 09:29

block some actions for projects on previous run engine

e155aad

fix worker group tests

23e8d37

fix triggerAndWait test

fb5b2e7

one typescript version to rule them all

f94154a

redlock type patch

23f3400

fix type issues caused by ts-reset

5f07ff2

improve cleanup scripts

46c79e0

add missing socket.io dep

accf9f7

fix run notification handler type

0b0b7da

fix worker group test again

fa8bfc9

generate prisma client for e2e tests

958c439

remove worker group tests for now

c8f460e

prevent image pull rate limits during unit tests

082644e

increase timeout for queue concurrency limit test

95a7155

generate prisma client for preview release

610c95f

nicktrn and others added 3 commits December 18, 2024 18:46

same node types everywhere

b1604fb

Merge branch 'main' into run-engine-2

079bd5c

Updated engine readme, removed legacy system notes

14250d5

matt-aitken reviewed Dec 19, 2024

View reviewed changes

nicktrn added 6 commits December 20, 2024 13:16

use default machine preset from platform package

56979e6

worker instances plural in schema

ae6a473

disable pnpm update notifications

482a98d

return worker group details from connect call

d3386e2

add workers admin route

7d382ac

fix heartbeat route return type

a759bf7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run Engine 2.0 (alpha) #1575

Run Engine 2.0 (alpha) #1575

nicktrn commented Dec 17, 2024

changeset-bot bot commented Dec 17, 2024 •

edited

Loading

coderabbitai bot commented Dec 17, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

pkg-pr-new bot commented Dec 18, 2024 •

edited

Loading

matt-aitken Dec 19, 2024

Run Engine 2.0 (alpha) #1575

Are you sure you want to change the base?

Run Engine 2.0 (alpha) #1575

Conversation

nicktrn commented Dec 17, 2024

changeset-bot bot commented Dec 17, 2024 • edited Loading

⚠️ No Changeset found

coderabbitai bot commented Dec 17, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

pkg-pr-new bot commented Dec 18, 2024 • edited Loading

matt-aitken Dec 19, 2024

Choose a reason for hiding this comment

changeset-bot bot commented Dec 17, 2024 •

edited

Loading

coderabbitai bot commented Dec 17, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented Dec 18, 2024 •

edited

Loading