Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #306 - Retrieve parentId by realm name #307

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Fix #306 - Retrieve parentId by realm name #307

merged 3 commits into from
Apr 19, 2024

Conversation

TuningYourCode
Copy link
Contributor

This change will fix #306 as it will try to retrieve the uuid of the given realm first and pass it as parentId.

It is a quiet similar solution like in https://github.com/treydock/puppet-module-keycloak/blob/master/lib/puppet/provider/keycloak_ldap_mapper/kcadm.rb#L127

@treydock
Copy link
Owner

@TuningYourCode Can you please rebase this PR against this repo's master branch? There was a recently merged fix that's needed to get tests passing

@treydock
Copy link
Owner

The unit tests here need updates:

Might be just

allow(resource.provider).to receive(:get_parent_id).with('test').and_return('test')

@TuningYourCode
Copy link
Contributor Author

Thanks for the fix - didn't had time yet to look at it :)

@treydock treydock merged commit 9a42b33 into treydock:master Apr 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Difficulties to create an user provider for master realm
2 participants