add comment
node that contains plain comments content
#231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋🏻,
I'm working on https://github.com/mrnossiom/lspelling that use TS to extract strings and identifiers from source code to spellcheck them. The grammar works fine to extract
doc_comments
content, string literals content.This PR adds a
comment
field online_comment
andblock_comment
that contain acomment
node with the comment content. It enables easy access to comment content without having to do node matching and strip comment markers based on the node type.This change matches other parts of the grammar, like
string_content
ordoc_comment
.Names for both the
node
and thefield
feel a bit too generic to me. Maybe node:comment_content
andcontent
?I intend to propose such a change on other grammars as well. I was wondering if such a change would have a significant perf impact.