Update default user to travis, ssh-key issue fix #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joepvd Please review the changes. |
|
Thanks! I'd like to test this with our different setups, so this does not break anything in a subtle way. I'll get back to this. |
|
I can confirm these changes work on the cluster at the OSUOSL. |
|
Hey @joepvd - Did you get a chance to validate this PR on your different setup's ? |
|
@joepvd - Any updates on above ? |
|
@joepvd any updates? |
|
Any updates from Travis-CI team on this PR ? |
|
hey @joshk - Any review comments on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR is trying to fix?
The base images created using old cloud.cfg were not able to get new ssh keys provided during instance boot via openstack, this meant only single ssh key could be used to access the image which was used while the image creation. This PR sets the travis user as default user which allows the VM to get keys provided during instance boot.
What approach did you choose and why?
Modified the cloud.cfg template to set travis user as the default user, this allows new ssh-keys to be added to travis user during instance boot.
How can you make sure the change works as expected?
The changes were tested locally by creating new image and instance.
Would you like any additional feedback?