Implement PO to QPH conversion #3545
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add tests to ensure this works? I guess you don't need |
|
@rschiang we'd love to land this code but we really do need some tests. If you need help writing them then please visit us in https://gitter.im/translate/dev |
|
Sorry for bumping the thread. Things happened and I totally forgot there was a PR here. 😳 Yes. As QPH is a phrasebook file format, it's more likely for users to import translations from external sources, and I see little use of providing As for the tests, I'll see if I could make something out this week. Thanks for the tip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements PO file to QPH conversion.
Not quite sure about naming conventions, please let me know if there were any glitches. :)