Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Make a new entry point for Next.js only #38

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

BasixKOR
Copy link

@BasixKOR BasixKOR commented Feb 7, 2022

Hi!

I just wanted to use this package really but I found that this package is tied to Next.js directly as discussed in #2.

This PR makes the <Img> component to simple img tag with optional react-static-tweets/next entry point that allows to use Next.js image optimization as usual.

This PR is a breaking change. Existing users who want to keep using Next.js images should change their code to import from react-static-tweets/next instead.

@vercel
Copy link

vercel bot commented Feb 7, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @transitive-bullshit on Vercel.

@transitive-bullshit first needs to authorize it.

BasixKOR added a commit to BasixKOR/basixpage that referenced this pull request Feb 11, 2022
@transitive-bullshit
Copy link
Owner

Hey @BasixKOR, thanks for the PR. I definitely like the approach & wasn't aware of peerDependenciesMeta before.

Not sure how I feel about all the duplicated files, though.

Going to spend some time considering options and get back to you.

Thanks again 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants