Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Aliased Dependencies in NPM #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DarkaMaul
Copy link

At the moment, the support for NPM dependencies fails at aliased dependencies.

Example for angular package.json

    "@types/node": "^16.11.7",
    "@types/selenium-webdriver": "3.0.7",
    "@types/selenium-webdriver4": "npm:@types/[email protected]",
    "@types/semver": "^7.3.4",
    "@types/shelljs": "^0.8.6",

This PR tries to handle this case by :

  • Adding an AliasedDependency class that inherits from Dependencies.
  • Installing dependencies from the real source instead of the alias name

@DarkaMaul DarkaMaul marked this pull request as ready for review February 21, 2024 13:11
@DarkaMaul DarkaMaul changed the title WIP: Support Aliased Dependencies in NPM Support Aliased Dependencies in NPM Feb 21, 2024
@woodruffw woodruffw added the enhancement New feature or request label Mar 13, 2024
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed this for overall structure, and LGTM! The pip-audit CI will be fixed with #84, so we can merge here without that.

CC @ESultanik for a review as well -- I think you know it-depends much better than I do 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants