refactor(plotter,renderer): convert coordinates to SVG instead of `transform` #395

mcous · 2022-10-23T14:33:20Z

No description provided.

codecov · 2022-10-23T14:34:14Z

Codecov Report

Merging #395 (6f630ce) into v5 (b7a8779) will decrease coverage by 2.37%.
The diff coverage is 92.59%.

❗ Current head 6f630ce differs from pull request most recent head 7010fef. Consider uploading reports for the commit 7010fef to get more accurate results

@@            Coverage Diff             @@
##               v5     #395      +/-   ##
==========================================
- Coverage   93.53%   91.16%   -2.38%     
==========================================
  Files          36       36              
  Lines        4348     4651     +303     
  Branches      604      613       +9     
==========================================
+ Hits         4067     4240     +173     
- Misses        281      411     +130

Impacted Files	Coverage Δ
packages/identify-layers/src/constants.ts	`100.00% <ø> (ø)`
packages/plotter/src/bounding-box.ts	`100.00% <ø> (+0.86%)`	⬆️
packages/plotter/src/graphic-plotter/plot-macro.ts	`30.08% <64.28%> (-10.43%)`	⬇️
packages/renderer/src/render.ts	`70.62% <77.41%> (+4.75%)`	⬆️
packages/identify-layers/src/get-common-cad.ts	`100.00% <100.00%> (ø)`
packages/identify-layers/src/get-matches.ts	`100.00% <100.00%> (ø)`
packages/identify-layers/src/index.ts	`100.00% <100.00%> (ø)`
packages/identify-layers/src/layer-types.ts	`100.00% <100.00%> (ø)`
packages/identify-layers/src/matchers.ts	`100.00% <100.00%> (ø)`
packages/identify-layers/src/types.ts	`100.00% <100.00%> (ø)`
... and 38 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

mcous · 2022-10-23T15:13:18Z

Current dependencies on/for this PR:

v5
- PR chore: upgrade dependencies #394
  - PR refactor(identify-layers)!: rename whats-that-gerber to @tracespace/identify-layers #407
    - PR fix(parser): recognize drill file header markers #398
      - PR refactor(plotter,renderer): convert coordinates to SVG instead of transform #395 👈
        
        PR feat(core): add tracespace core package #402
        
        PR refactor(cli)!: rewrite CLI on new render pipeline #405
        
        PR chore(release): 5.0.0-alpha.0 #406
        
        PR feat(www): add initial tracespace view page #397
        
        PR chore(www): update build and test environment #396

This comment was auto-generated by Graphite.

This was referenced Oct 23, 2022

chore: upgrade dependencies #394

Merged

chore(www): update build and test environment #396

Closed

feat(www): add initial tracespace view page #397

Draft

mcous force-pushed the v5-view_plotter branch 2 times, most recently from a1c2cf4 to ad8d636 Compare October 23, 2022 15:13

mcous force-pushed the v5-view_plotter branch from ad8d636 to f13875d Compare October 23, 2022 15:38

mcous changed the title ~~refactor(plotter): rework plotter external typings~~ refactor(plotter,renderer): convert coordinates to SVG-space instead of transform Oct 23, 2022

mcous changed the title ~~refactor(plotter,renderer): convert coordinates to SVG-space instead of transform~~ refactor(plotter,renderer): convert coordinates to SVG instead of transform Oct 23, 2022

mcous changed the title ~~refactor(plotter,renderer): convert coordinates to SVG instead of transform~~ refactor(renderer): convert coordinates to SVG instead of transform Oct 23, 2022

mcous changed the base branch from v5-view_config to v5-parser_drill-header October 23, 2022 16:03

mcous force-pushed the v5-view_plotter branch from f13875d to 71b0113 Compare October 23, 2022 16:03

mcous mentioned this pull request Oct 23, 2022

fix(parser): recognize drill file header markers #398

Merged

mcous force-pushed the v5-parser_drill-header branch from cec5cf6 to 5fa2efa Compare October 23, 2022 16:28

mcous force-pushed the v5-view_plotter branch from 71b0113 to 9441d48 Compare October 23, 2022 16:28

mcous force-pushed the v5-parser_drill-header branch from 5fa2efa to eb917c8 Compare December 20, 2022 19:22

mcous force-pushed the v5-view_plotter branch from 9441d48 to daa2d9b Compare December 20, 2022 19:22

mcous force-pushed the v5-parser_drill-header branch from eb917c8 to 259cd43 Compare December 20, 2022 19:52

mcous force-pushed the v5-view_plotter branch from daa2d9b to 624cb5b Compare December 20, 2022 19:52

mcous force-pushed the v5-parser_drill-header branch from 259cd43 to d537bf3 Compare December 27, 2022 20:08

mcous force-pushed the v5-view_plotter branch from 624cb5b to 6f630ce Compare December 27, 2022 20:08

mcous force-pushed the v5-parser_drill-header branch from d537bf3 to 40868e9 Compare December 27, 2022 20:23

mcous force-pushed the v5-view_plotter branch from 6f630ce to 593774c Compare December 27, 2022 20:23

mcous force-pushed the v5-parser_drill-header branch from 40868e9 to 9c5d954 Compare December 27, 2022 20:35

mcous force-pushed the v5-view_plotter branch from 593774c to 24d6d01 Compare December 27, 2022 20:35

mcous mentioned this pull request Dec 27, 2022

feat(core): add tracespace core package #402

Merged

mcous force-pushed the v5-parser_drill-header branch from 9c5d954 to 02e4780 Compare January 15, 2023 22:36

mcous force-pushed the v5-view_plotter branch from 24d6d01 to 87d5c73 Compare January 15, 2023 22:36

mcous mentioned this pull request Jan 15, 2023

refactor(cli)!: rewrite CLI on new render pipeline #405

Merged

mcous mentioned this pull request Jan 15, 2023

chore(release): 5.0.0-alpha.0 #406

Merged

mcous marked this pull request as ready for review January 15, 2023 22:47

mcous force-pushed the v5-parser_drill-header branch from 02e4780 to 8c8a485 Compare January 15, 2023 23:47

mcous force-pushed the v5-view_plotter branch from 87d5c73 to 4b785c1 Compare January 15, 2023 23:47

mcous marked this pull request as draft January 15, 2023 23:47

mcous mentioned this pull request Jan 15, 2023

refactor(identify-layers)!: rename whats-that-gerber to @tracespace/identify-layers #407

Merged

mcous changed the title ~~refactor(renderer): convert coordinates to SVG instead of transform~~ refactor(plotter,renderer): convert coordinates to SVG instead of transform Jan 15, 2023

mcous force-pushed the v5-parser_drill-header branch from 8c8a485 to deea9b1 Compare January 15, 2023 23:58

mcous force-pushed the v5-view_plotter branch from 4b785c1 to 2feea6d Compare January 15, 2023 23:58

mcous force-pushed the v5-parser_drill-header branch from deea9b1 to cd098f7 Compare January 16, 2023 00:02

mcous force-pushed the v5-view_plotter branch from 2feea6d to c79b906 Compare January 16, 2023 00:02

mcous force-pushed the v5-parser_drill-header branch from cd098f7 to aec849a Compare January 16, 2023 00:08

mcous force-pushed the v5-view_plotter branch from c79b906 to ebd0c03 Compare January 16, 2023 00:08

Base automatically changed from v5-parser_drill-header to v5 January 16, 2023 00:10

refactor(renderer): convert coordinates to SVG instead of transform

7010fef

mcous force-pushed the v5-view_plotter branch from ebd0c03 to 7010fef Compare January 16, 2023 00:11

mcous marked this pull request as ready for review January 16, 2023 00:11

mcous merged commit d37eed5 into v5 Jan 16, 2023

mcous deleted the v5-view_plotter branch January 16, 2023 00:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(plotter,renderer): convert coordinates to SVG instead of `transform` #395

refactor(plotter,renderer): convert coordinates to SVG instead of `transform` #395

mcous commented Oct 23, 2022

codecov bot commented Oct 23, 2022 •

edited

mcous commented Oct 23, 2022 •

edited

refactor(plotter,renderer): convert coordinates to SVG instead of transform #395

refactor(plotter,renderer): convert coordinates to SVG instead of transform #395

Conversation

mcous commented Oct 23, 2022

codecov bot commented Oct 23, 2022 • edited

Codecov Report

mcous commented Oct 23, 2022 • edited

refactor(plotter,renderer): convert coordinates to SVG instead of `transform` #395

refactor(plotter,renderer): convert coordinates to SVG instead of `transform` #395

codecov bot commented Oct 23, 2022 •

edited

mcous commented Oct 23, 2022 •

edited