Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layer-types.js #390

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update layer-types.js #390

wants to merge 1 commit into from

Conversation

Heegiiny
Copy link

No description provided.

@mcous
Copy link
Member

mcous commented Jul 18, 2022

Thanks for the contribution @Heegiiny! Would you mind adding test cases for your changes to the file name test fixture? See packages/fixtures/gerber-filenames.json

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #390 (62de154) into main (49c9a22) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #390   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files          75       75           
  Lines        2405     2405           
  Branches       58       58           
=======================================
  Hits         2087     2087           
  Misses        316      316           
  Partials        2        2           
Impacted Files Coverage Δ
packages/whats-that-gerber/lib/layer-types.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49c9a22...62de154. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants