Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release #44

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Release #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c7e1e83
feat: replace elliptice with noble curves
ieow Sep 25, 2024
d512d5c
fix: unpad sharedsecret to match prev elliptic
ieow Sep 25, 2024
7b495f3
feat: remove Buffer
ieow Nov 1, 2024
ef94903
fix: remove redundant func
ieow Nov 1, 2024
d4cb1e4
fix: test
ieow Nov 1, 2024
544dd92
Merge pull request #42 from torusresearch/feat/nobleCurves
himanshuchawla009 Nov 1, 2024
c20df13
Release 6.0.0-0
himanshuchawla009 Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 67 additions & 50 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@toruslabs/eccrypto",
"version": "5.0.4",
"version": "6.0.0-0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why -0?

"description": "JavaScript Elliptic curve cryptography library, includes fix to browser.js so that encrypt/decrypt works",
"main": "./dist/lib.cjs/index.js",
"module": "./dist/lib.esm/index.js",
Expand Down Expand Up @@ -32,7 +32,6 @@
"cryptography",
"secp256k1",
"K-256",
"elliptic",
"curve"
],
"author": "Torus Labs",
Expand All @@ -52,7 +51,6 @@
"@toruslabs/torus-scripts": "^6.1.5",
"@types/buffer-equal": "^1.0.2",
"@types/chai": "^4.3.16",
"@types/elliptic": "^6.4.18",
"browserify": "^17.0.1",
"buffer-equal": "^1.0.1",
"chai": "^4.3.7",
Expand All @@ -74,6 +72,6 @@
"npm": ">=9.x"
},
"dependencies": {
"elliptic": "^6.5.7"
"@noble/curves": "^1.6.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as mentioned, if we only use secp256k1, we could use the more compact package @noble/secp256k1 package. See here for more details on the differences. not saying this is necessary (not sure how much package size this actually saves), but wanted to mention the option.

}
}
Loading
Loading