Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug40168+34088 035 v2 #2123

Open
wants to merge 15 commits into
base: maint-0.3.5
Choose a base branch
from
Open

Bug40168+34088 035 v2 #2123

wants to merge 15 commits into from

Conversation

asn-d6
Copy link
Member

@asn-d6 asn-d6 commented Dec 21, 2020

No description provided.

Mike Perry added 15 commits November 23, 2020 21:32
Completely ignore abandoned circs from circ timeout calc
7fc4460 
This prevents the timeout curve from getting spread out as much, resulting in
more accurate timeout values for quantiles from 60-80.
Lower min circ timeout from 1.5s to bin width (10ms)
1d5f83b
Raise the circuit close time quantile to 99.
6c68f1f 
This should allow us to more accurately estimate pareto parameters
without relying on "right-censorship" of circuit build timeout values.
Log circuit timeout in milliseconds
f410936
Lower circuit build time bin width to 10ms.
b9e3b98 
50ms is not enough resolution. CBT can be as low as 80ms in datacenter
clients close to their relays.
Fix Xm mode calculation to properly average N=10 modes.
88fa853 
This is still fast enough. ~100usec on my laptop with 1000 build times.
Bug 40168 changes file
15daf87
Bug 34088: Remove max timeout calculation and warning.
960a859 
With the maximum likelihood estimator for alpha from #40168, we no longer need
max_time to calculate alpha.
Bug 34088: Changes file
2558933
fixup! Bug 40168 changes file
b658f31 
histogram spelling fix
fixup! Completely ignore abandoned circs from circ timeout calc
a86bdfb 
Make assert nonfatal.
Update documentation for the number of modes for Xm estimator.
c5f8593
fixup! Fix Xm mode calculation to properly average N=10 modes.
fed3cfc 
Update function documentation for 10 modes.
Add CBT unit test for Xm and alpha estimation.
38033b0
fixup! Completely ignore abandoned circs from circ timeout calc
20f998c 
Remove dead close_ms var.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10500

  • 19 of 20 (95.0%) changed or added relevant lines in 1 file are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.7%) to 60.97%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/core/or/circuitstats.c 19 20 95.0%
Files with Coverage Reduction New Missed Lines %
src/core/or/circuitstats.c 2 80.29%
src/feature/dirauth/shared_random.c 4 85.1%
src/feature/dirauth/dirvote.c 9 64.65%
Totals Coverage Status
Change from base Build 10353: 1.7%
Covered Lines: 44612
Relevant Lines: 73171
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asn-d6 @coveralls