Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new approach for builder pattern #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
165 changes: 100 additions & 65 deletions builder/builder.ts
Original file line number Diff line number Diff line change
@@ -1,69 +1,104 @@
namespace BuilderPattern {
export class UserBuilder {
private name: string;
private age: number;
private phone: string;
private address: string;

constructor(name: string) {
this.name = name;
}

get Name() {
return this.name;
}
setAge(value: number): UserBuilder {
this.age = value;
return this;
}
get Age() {
return this.age;
}
setPhone(value: string): UserBuilder {
this.phone = value;
return this;
}
get Phone() {
return this.phone;
}
setAddress(value: string): UserBuilder {
this.address = value;
return this;
}
get Address() {
return this.address;
}

build(): User {
return new User(this);
}
}

export class User {
private name: string;
private age: number;
private phone: string;
private address: string;

constructor(builder: UserBuilder) {
this.name = builder.Name;
this.age = builder.Age;
this.phone = builder.Phone;
this.address = builder.Address
}

get Name() {
return this.name;
}
get Age() {
return this.age;
}
get Phone() {
return this.phone;
}
get Address() {
return this.address;
}
export interface Builder<T> {
build(): T;
}

export class User {
private name: string;
private age: number;
private phone: string;
private address: string;

constructor(builder: UserBuilder) {
this.name = builder.Name;
this.age = builder.Age;
this.phone = builder.Phone;
this.address = builder.Address;
}

get Name() {
return this.name;
}
get Age() {
return this.age;
}
get Phone() {
return this.phone;
}
get Address() {
return this.address;
}
}

export interface Director<T> {
create(): T;
}

export class UserBuilder implements Builder<User> {
private name: string;
private age: number;
private phone: string;
private address: string;

constructor(name: string) {
this.name = name;
}

setAge(value: number): UserBuilder {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit misleading to have getter by declaring with get and setters following Java POJO.
Here, methods should be introduced with set keyword.

this.age = value;
return this;
}

setPhone(value: string): UserBuilder {
this.phone = value;
return this;
}

setAddress(value: string): UserBuilder {
this.address = value;
return this;
}

getUser() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I see, getUser is not used, and seems superfluous, since we have a build method.

return this;
}

build(): User {
return new User(this);
}

get Name() {
return this.name;
}

get Age() {
return this.age;
}

get Phone() {
return this.phone;
}

get Address() {
return this.address;
}
}

export class UserDirector implements Director<User> {
constructor(private userBuilder: UserBuilder) {}

create() {
if (this.userBuilder.Name === 'Jancsi') {
this.userBuilder.setAge(12)
.setPhone('0123456789')
.setAddress('asdf');
} else {
this.userBuilder.setAge(0)
.setPhone('xxxxxxxxx')
.setAddress('xxxx');
}

return this.userBuilder.build();
}
}
}
13 changes: 6 additions & 7 deletions builder/demo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,12 @@
namespace BuilderPattern {
export namespace Demo {
export function show() : void {
var u: BuilderPattern.User = new BuilderPattern.UserBuilder("Jancsi")
.setAge(12)
.setPhone("0123456789")
.setAddress("asdf")
.build();
console.log(u.Name + " " + u.Age + " " + u.Phone + " " + u.Address);
let userBuilder: BuilderPattern.UserBuilder = new BuilderPattern.UserBuilder("Jancsi");
let director: BuilderPattern.UserDirector = new BuilderPattern.UserDirector(userBuilder);
let user: BuilderPattern.User = director.create();

console.log(user.Name + " " + user.Age + " " + user.Phone + " " + user.Address);
}
}
}