Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only retrieve the pages that are registered in the settings #226
base: main
Are you sure you want to change the base?
Only retrieve the pages that are registered in the settings #226
Changes from 5 commits
960abb4
3cc9ca2
40c490a
f49d0b9
f4a16c4
67270dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding
news_post = NewsPageFactory(parent=self.home)
before the execute and add a check to ensure the news page doesn't appear in the resultsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be simplified as:
pages = pages.filter(content_type__app_label__in=grapple_settings.APPS)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additionally, we still support the old dict-style declaration. https://cs.github.com/GrappleGQL/wagtail-grapple/blob/9b8a49c05ddc74673e980e6a359c9f642aae8877/grapple/actions.py?q=grapple_settings.APPS#L55-L63
Perhaps use
registry.apps
- https://cs.github.com/GrappleGQL/wagtail-grapple/blob/9b8a49c05ddc74673e980e6a359c9f642aae8877/grapple/registry.py#L62 for this