Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auth requests #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkevingutierrez
Copy link

@jkevingutierrez jkevingutierrez commented Sep 19, 2023

Fix requests that require extra authentication, for example, when using IAP in Google Cloud


  • Stay on point and keep it small so it can be easily reviewed. For example, try to apply any general refactoring separately outside of the PR.
  • Consider adding unit tests, especially for bug fixes. If you don't, tell us why: It will require the creation of a server that will need authentication to test it.
  • All new and existing tests pass.
  • Linting passes.
  • Consider updating documentation. If you don't, tell us why: Small change. No need to update it
  • List the environments / platforms in which you tested your changes: Chrome 116.0.5845.179 in mac 13.5.2.

Fix requests that require extra authentication, for example, when using IAP in Google Cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant