Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

完善 \think\facade\Log 里的方法参数类型注释 #2975

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

big-dream
Copy link
Contributor

原本是标注为 mixed 类型,但实际只支持 string|\Stringable。注释标注错误,导致参数传入错误的数据类型时 IDE 未提示

@liu21st liu21st merged commit afd7222 into top-think:8.0 Jul 18, 2024
5 checks passed
@liu21st
Copy link
Member

liu21st commented Jul 18, 2024

主要是为了兼容3.0之前的规范 所以类里面参数没有约束 不过注释调整应该没问题

@big-dream big-dream deleted the 8.0-log branch September 13, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants