Answer:6 Permissions #865
Closed
Answer:6 Permissions #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move matching logic into the store
Add other role components Add CanMatchFn guards Add signal to the store for admin Extract a method on the store to handle just the role matching. Refactor use of the store from the directive so that the store doesn't have to deal with undefined
github-actions
bot
added
6
tomalaforge
reviewed
May 10, 2024
| this.vcr.createEmbeddedView(this.templateRef); | ||
| } | ||
| } | ||
| }); |
tomalaforge
reviewed
May 10, 2024
|
|
||
| @Injectable({ | ||
| providedIn: 'root', | ||
| }) | ||
| export class UserStore { | ||
| private user = new BehaviorSubject<User | undefined>(undefined); | ||
| user$ = this.user.asObservable(); | ||
| private _user = signal<User | undefined>(undefined); |
There was a problem hiding this comment.
I think, if you are used to the _ naming convention for private field, you should switch to # which is a real javascript private field
|
Perfect solution with the use of signals |
|
This pull request is stale because it has been open for 15 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for challenge submission
Warning:
Alternatively, you can still submit your PR to join the list of answered challenges or to be reviewed by a community member. 馃敟