Answer: 50: Bug in effect solution

[svenson95]

Here is my solution for this challenge. It was very interesting to investigate the problem and understand what is happening here. I've made some comments explaining my thought process, feel free to correct me 😄

[tomalaforge]

yes that's one solution,
I think I prefer to have one signal per effect, easier to read, easier to maintain
or maybe create a computed signal and listen to this one in the effect.

[LMFinney]

With this implementation, the alert will be shown when you have 2 or 3 of them checked, and then you uncheck one (because name || age || address will still be true if any of them are true). I think that's not what @tomalaforge wants. I think he wants the alert to show when each checkbox is checked, independent of the state of any other, but not as the result of unchecking.

Thomas can clarify, of course.

[svenson95]

Yes but i wasn't really sure what is part of the challenge and what's not. This is the simplest solution without changing the code a lot. As thomas already mentioned, this could be solved with a computed signal as well. I already have some things in mind, i'll update the docs for this challenge.

[LMFinney]

I think we need clarification on the requirements.

[tomalaforge]

@LMFinney you are right, but I didn't go that far 😅
My goal was to trigger the effect when we check or uncheck one checkbox which is not the case if the first one is true. But I didn't think of your case @LMFinney; So I should change the instruction to be clearer indeed 👍

[svenson95]

yes that's one solution, I think I prefer to have one signal per effect, easier to read, easier to maintain or maybe create a computed signal and listen to this one in the effect.

i'll add this as a bonus step in the challenge, and update my solution afterwards