[WIP] Listening Rooms #128
Conversation
|
My holy god. This feature is finally coming! Huzzah! (pardon cheers from peanut gallery) |
|
Since 367649e which I just pushed, all core Listening Rooms operations should work. One can start a room and become DJ, and others can join in and become listeners. Aside from a few crashes here and there, it is usable, though not quite ready for merging. |
|
Awesome! Do you want feedback from testing as well? Or would you rather wait for your December changes? |
| @@ -61,6 +61,8 @@ SET( tomahawkSourcesGui ${tomahawkSourcesGui} | |||
| sourcetree/items/PlaylistItems.cpp | |||
| sourcetree/items/CategoryItems.cpp | |||
| sourcetree/items/GenericPageItems.cpp | |||
| sourcetree/items/ListeningRoomItem.cpp | |||
| sourcetree/items/ListeningRoomsCategoryItem.cpp | |||
There was a problem hiding this comment.
Super nitpick: one is plural one is not :)
|
One thing just came to mind---since a listening room's default playlist interface is just the source playlist interface, we probably want to change the default listen along behaviour for listening rooms to be "locked on"---that is, if a DJ skips a song, listeners should immediately skip too, unlike listening along. Being synchronized in the same room is more important. |
|
|
||
|
|
||
| void | ||
| ListeningRoomModel::endRoomChanges() |
There was a problem hiding this comment.
I wonder if we can somehow share the add/remove/move logic between Playlist and ListeningRoom. I added the m_savedInsertPos + move/etc logic to handle spotify syncing (we need incremental changes not just full revisions), but it seems fragile now to have to maintain this tricky code in two places.
This means that after this commit, all core Listening Room operations should work, for both DJs and listeners. Optimized LR model updating so we don't reload unless stuff has really changed. Also added tons of debug spam and a little debug UI.
|
Would love to get this into master soon :) thanks! |
|
4 months since my comment. Why isnt this getting merged? :) |
|
On Mon, Aug 12, 2013 at 11:15 AM, Andreas Cederström
Because it's not ready for merging yet, it needs some finishing and It is on my to-do list, it will take a while more, and it will be |
|
meant to stress you man. just wanted to know the current status. appreciate your efforts :) |
Builds ok, but functionality is broken. Conflicts: resources.qrc src/CMakeLists.txt src/libtomahawk/ActionCollection.cpp src/libtomahawk/CMakeLists.txt src/libtomahawk/LatchManager.cpp src/libtomahawk/Source.cpp src/libtomahawk/Source.h src/libtomahawk/Typedefs.h src/libtomahawk/ViewManager.cpp src/libtomahawk/ViewManager.h src/libtomahawk/database/DatabaseCommand.cpp src/libtomahawk/playlist/PlayableItem.cpp src/tomahawk/TomahawkApp.cpp src/tomahawk/TomahawkWindow.cpp src/tomahawk/sourcetree/SourceDelegate.cpp src/tomahawk/sourcetree/SourceTreeView.cpp src/tomahawk/sourcetree/SourcesModel.cpp src/tomahawk/sourcetree/SourcesModel.h src/tomahawk/sourcetree/items/CategoryItems.cpp src/tomahawk/sourcetree/items/CategoryItems.h
Also disabled PartyModel and related widgets.
|
All i want for christmas is listening rooms :) |
|
@teo out of curiosity, what's the current state here? :) |
|
Unfinished, it still requires a bit of work. |
|
@teo I know this has been a while, but do you still remember what work is remaining? I figure if you write it down, there's a higher chance of it being picked up on. Maybe I'll even take a look... |
|
Any news? its a feature that lacks in tomahawk compared to other music player... |
They are rooms. You can listen to music in them. What's there not to like?
Seriously though, this is an extension of the "listen along" concept. Still WiP, but the idea is for listeners to be able to see what's upcoming and track history, and submit suggestions. Listening Rooms also appear superficially like playlists, but they are not persistent, and the track operations are very different.
This Listening Rooms concept is not like Soundrop, it is not massive democratic music listening, but rather the idea is to allow a person to host a party, and guests to occasionally chip in.