Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appender: bump thiserror to v2 #3172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

appender: bump thiserror to v2 #3172

wants to merge 1 commit into from

Conversation

paolobarbolini
Copy link

Motivation

The ecosystem has upgraded to thiserror v2, so this crate was causing duplicate dependency versions.

Solution

Bump thiserror to v2 - https://github.com/dtolnay/thiserror/releases/tag/2.0.0

@paolobarbolini paolobarbolini requested a review from a team as a code owner December 7, 2024 07:16
@paolobarbolini paolobarbolini mentioned this pull request Dec 7, 2024
Merged
sourcefrog added a commit to sourcefrog/cargo-mutants that referenced this pull request Dec 7, 2024
@sourcefrog
build: bump locked dependencies (#469)
5d175d9 
Bumps all locked dependencies, fixing the following issues:

* Building for s390x musl
* Building for loongarch64 gnu/musl
* [RUSTSEC-2021-0139](https://rustsec.org/advisories/RUSTSEC-2021-0139)
on ansi_term (unmaintained)
* [RUSTSEC-2024-0320](https://rustsec.org/advisories/RUSTSEC-2024-0320)
on yaml-rust (unmaintained)
* [RUSTSEC-2024-0404](https://rustsec.org/advisories/RUSTSEC-2024-0404)
on anstream (unsound)
* Removes some duplicate dependency versions and some unused
dependencies - on this I've also opened
tokio-rs/tracing#3172 but it'll probably take a
long time to get released

Remains:

* [RUSTSEC-2024-0375](https://rustsec.org/advisories/RUSTSEC-2024-0375)
on atty (unmaintained)
Rustin170506
Rustin170506 approved these changes Dec 8, 2024
View reviewed changes
Copy link
Contributor

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :shipit:

Not sure if we also need to bump the examples thiserror dependency.

I guess it is OK to bump it too in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paolobarbolini @Rustin170506