enhancement: add gauge metric behind feature #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance it will be merged? |
jtescher
approved these changes
Apr 29, 2024
mladedav
reviewed
Apr 29, 2024
| async fn i64_gauge_with_attributes_is_exported() { | ||
| let (subscriber, exporter) = init_subscriber( | ||
| "hello_world".to_string(), | ||
| InstrumentKind::Counter, |
There was a problem hiding this comment.
Shouldn't these tests use Gauge?
This shouldn't even work because the metric shouldn't be downcastable to Sum or maybe I'm missing something there, but this seems suspicious to me.
I think it would be best to add a test that calls tracing::info twice with different values to test that the value is overwritten and not summed like for counter metrics.
This was referenced Apr 30, 2024
Merged
|
Hello guys, I made an another pr based on the branch |
|
since #129 is merged - this one can be closed |
|
@academiaresf thanks for jumpstarting this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The opentelemetry crate actually supports
Gaugemetric behindotel_unstablefeature.Solution
Extend the current implementation with the treatment for the new
Gaugemetric.The tests are passing but i don't know if there are necessary other type of tests (at this point, the property
start_timeinside theDataPointsof theGaugetype areNonein all the test, for example. L664 of tests/metrics_publishing.rs file).