tokio(metrics): fix blocking_threads count #6551
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
R-loom-multi-thread
Darksonn
reviewed
May 11, 2024
Co-authored-by: Alice Ryhl <[email protected]>
Darksonn
reviewed
May 12, 2024
| @@ -8,7 +8,8 @@ impl Handle { | |||
| } | |||
|
|
|||
| pub(crate) fn num_blocking_threads(&self) -> usize { | |||
| self.blocking_spawner.num_threads() | |||
| // workers are currently spawned within the blocking_spawned | |||
There was a problem hiding this comment.
Suggested change
| // workers are currently spawned within the blocking_spawned | |
| // workers are currently spawned using spawn_blocking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #6550
Solution
For the multithreaded scheduler handles, subtract the number of worker threads from the blocking threads count.